-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation server and demo frontend #49
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Embarks partial fix for #7 |
Waino
force-pushed
the
feat/translation-server
branch
from
March 4, 2024 09:52
e7c90b7
to
9157415
Compare
Merged
Waino
force-pushed
the
feat/translation-server
branch
from
March 11, 2024 08:29
ddf3c26
to
13d844b
Compare
TimotheeMickus
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'd be in favor of fixing the mammoth emoji to google's noto color, but what's there is good enough for a demo
Waino
force-pushed
the
feat/translation-server
branch
from
April 15, 2024 06:50
e48e011
to
89186bb
Compare
@Waino do we merge? |
Required some changes to the inputters, to allow data to be passed in as StringIO instead of a path to a file.
Re-enabling this test would require the following: - An up-to-date config for a lightweight smoketest model - An actual model trained from said config - Updating the test to specify config and task_id
hydra-L-train-config.yml is a modified version of the training config, with sentencepiece transform added. server.json is required by the backend. expected_files lists the expected directory structure, with model and vocab files that are too large to include in this repo.
Waino
force-pushed
the
feat/translation-server
branch
from
May 27, 2024 07:44
89186bb
to
7a14eaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing translation server from OpenNMT-py was refurbished.
A demo frontend was implemented using streamlit.