Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation server and demo frontend #49

Merged
merged 12 commits into from
May 27, 2024
Merged

Translation server and demo frontend #49

merged 12 commits into from
May 27, 2024

Conversation

Waino
Copy link
Collaborator

@Waino Waino commented Jan 29, 2024

The existing translation server from OpenNMT-py was refurbished.
A demo frontend was implemented using streamlit.

@Waino Waino requested a review from TimotheeMickus January 29, 2024 16:19
@TimotheeMickus
Copy link
Collaborator

Embarks partial fix for #7

@Waino Waino force-pushed the feat/translation-server branch from e7c90b7 to 9157415 Compare March 4, 2024 09:52
@TimotheeMickus TimotheeMickus mentioned this pull request Mar 5, 2024
@Waino Waino force-pushed the feat/translation-server branch from ddf3c26 to 13d844b Compare March 11, 2024 08:29
Copy link
Collaborator

@TimotheeMickus TimotheeMickus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd be in favor of fixing the mammoth emoji to google's noto color, but what's there is good enough for a demo

@Waino Waino force-pushed the feat/translation-server branch from e48e011 to 89186bb Compare April 15, 2024 06:50
@TimotheeMickus
Copy link
Collaborator

@Waino do we merge?

Waino and others added 12 commits May 27, 2024 10:39
Required some changes to the inputters, to allow data to be passed in as
StringIO instead of a path to a file.
Re-enabling this test would require the following:
- An up-to-date config for a lightweight smoketest model
- An actual model trained from said config
- Updating the test to specify config and task_id
hydra-L-train-config.yml is a modified version of the training config,
with sentencepiece transform added.

server.json is required by the backend.

expected_files lists the expected directory structure, with model and
vocab files that are too large to include in this repo.
@Waino Waino force-pushed the feat/translation-server branch from 89186bb to 7a14eaa Compare May 27, 2024 07:44
@Waino Waino merged commit 4b9b544 into main May 27, 2024
2 checks passed
@Waino Waino deleted the feat/translation-server branch May 27, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants